search

AleksandarDev / vscode-sequence-diagrams

Generates UML sequence diagrams from simple text
https://marketplace.visualstudio.com/items?itemName=AleksandarDev.vscode-sequence-diagrams
47 stars 17 forks source link

add utf8 support #16

Closed lucasgao67 closed 5 years ago

lucasgao67 commented 5 years ago

solve problem save png failed as Uncaught InvalidCharacterError: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.

AleksandarDev commented 5 years ago

Hi lucas, thanks for contributing.

I see you used, seems like, outdated solution for the problem. See: https://stackoverflow.com/a/30106551

It would be nice to have, like in first example of the solution, separate function for converting UTF8 strings to base64.

On 6 Jul 2019, 05:16 +0200, lucas notifications@github.com, wrote:

solve problem save png failed as Uncaught InvalidCharacterError: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range. You can view, comment on, or merge this pull request online at: https://github.com/AleksandarDev/vscode-sequence-diagrams/pull/16 Commit Summary

• add utf8 support

File Changes

• M src/contentscript.js (2)

Patch Links:

• https://github.com/AleksandarDev/vscode-sequence-diagrams/pull/16.patch • https://github.com/AleksandarDev/vscode-sequence-diagrams/pull/16.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

lucasgao67 commented 5 years ago

i'll close,and pull with another branch