AleksandarDev / vscode-sequence-diagrams

Generates UML sequence diagrams from simple text
https://marketplace.visualstudio.com/items?itemName=AleksandarDev.vscode-sequence-diagrams
47 stars 16 forks source link

Plugin not rendering the diagram #23

Closed mitasoft closed 3 years ago

mitasoft commented 4 years ago

extension version v0.4.0

trying to render a sequence diagram based on the following:

Andrew->China: Says Hello
Note right of China: China thinks\nabout it
China-->Andrew: How are you?
Andrew->>China: I am good thanks!

Nothing is rendered in the diagram preview

homorozeanu commented 3 years ago

Same problem here!

Plugin version: v0.4.0 VSCode version: 1.50.1

Any update?

JoeMcB commented 3 years ago

Did some digging and it appears the extension is using either imprecise permissions or old webview resource access. In either case, updating the asset access fixes it. Attached a PR.

yzalvov commented 3 years ago

I am not able to use this extension of v0.4.1 with Visual Studio Code v1.51.0.

In my test.seqdiag I try the same content as @mitasoft and there's nothing rendered on the Sequence Diagram tab. I can see an error in the vscode debug console (screenshot below): Cannot read property 'webview' of undefined

Tried a completely fresh vscode install with only this extension – same negative result.

Screenshot 2020-11-08 at 17 26 00
JoeMcB commented 3 years ago

Resolved dual build systems with https://github.com/AleksandarDev/vscode-sequence-diagrams/pull/25

I think that will fix the current master issue but need to see it repubished to verify.

yzalvov commented 3 years ago

Great, thank you @JoeMcB !

I guess we have to wait for @AleksandarDev to make us all happy by a merge?

yzalvov commented 3 years ago

@JoeMcB please advise, how to fix locally before that PR merged?

AleksandarDev commented 3 years ago

@JoeMcB I'm getting following error after merging your changes. Maybe tsconfig.json is required after all.

❯ yarn vscode:prepublish
yarn run v1.22.4
warning vscode-sequence-diagrams@0.4.1: The engine "vscode" appears to be invalid.
$ webpack --mode production
[webpack-cli] Compilation finished
assets by status 538 KiB [cached] 15 assets
./src/extension.ts 39 bytes [built] [code generated] [2 errors]

ERROR in ./src/extension.ts
[tsl] ERROR
      TS18002: The 'files' list in config file 'tsconfig.json' is empty.

ERROR in ./src/extension.ts
Module build failed (from ./node_modules/ts-loader/index.js):
Error: error while parsing tsconfig.json
    at Object.loader (C:\Users\Aleks\Documents\GitHub\vscode-sequence-diagrams\node_modules\ts-loader\dist\index.js:19:18)

webpack 5.2.0 compiled with 2 errors in 3007 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
JoeMcB commented 3 years ago

Apologies for that. I'm not familiar with the publishing aspect here and suspect there's a configuration issue going from a development env to a package. I'll revisit when I can.

rafapolo commented 3 years ago

15,115 installs and waiting a fix for four months now :/

AleksandarDev commented 3 years ago

@rafapolo I'm currently unable to maintain this extension. Feel free to help @JoeMcB fixing the issue. I'll merge and publish new version moment it builds.

rafapolo commented 3 years ago

Hi @JoeMcB, any thoughts on this? This is such a nice and useful extension! It is a shame it is dead.

yzalvov commented 3 years ago

Hi @JoeMcB yes mate please share some love 💕

JoeMcB commented 3 years ago

I'll take a look when I can. 2 different build tools are being used between dev and prod. I encourage anyone interested to check this code out and work on it themselves. Best way to learn is to try!

JoeMcB commented 3 years ago

PR fixing build is ready @AleksandarDev

AleksandarDev commented 3 years ago

@JoeMcB Thanks for the PR. Build issues are now resolved and I have published the extension. But the issue of diagram not rendering is still present. I see no errors regarding that but I see error when "Preview" tab is closed:

image

JoeMcB commented 3 years ago

🤕 I'll check it out. It works in dev!

jvitrifork commented 3 years ago

It is still an issue. Have you had the time to have a look at it?