AleksandarDev / vscode-sequence-diagrams

Generates UML sequence diagrams from simple text
https://marketplace.visualstudio.com/items?itemName=AleksandarDev.vscode-sequence-diagrams
47 stars 16 forks source link

fix: allow loading of resources from workspace root and extension's i… #29

Closed chrishavekost closed 3 years ago

chrishavekost commented 3 years ago

…nstall directory

Fixes #23

I'm not very familiar with developing VSCode extensions, but it seems like this is all that's needed to allow sequence diagrams to render again when built with yarn vscode:prepublish

Screen Shot 2021-03-11 at 9.13.35 AM.png

chrishavekost commented 3 years ago

@AleksandarDev please let me know if you think there's anything else needed for this PR. It seems like allowing access to the user's workspace root fixes this, but I may be missing something.

JoeMcB commented 3 years ago

@AleksandarDev merge and we'll try it out? Clearly no one here really understands VS Code extensions but "Plugin is accidently overriding permissions that would make this work out-of-the-box?" is a good of explanation as any (and maybe explains some of the quirks of the plugin working for some dev envs but not others.)

AleksandarDev commented 3 years ago

@chrishavekost Thanks for the contribution. I published the extension under 0.4.4 version.

https://marketplace.visualstudio.com/items?itemName=AleksandarDev.vscode-sequence-diagrams

rafapolo commented 3 years ago

On 4.4 here, still not working. :/

rejected promise not handled within 1 second: Error: Unknown webview handle:231211bf-3f90-47ef-970c-3065e3e1e663 v @ console.ts:137 $logExtensionHostMessage @ mainThreadConsole.ts:35 _doInvokeHandler @ rpcProtocol.ts:417 _invokeHandler @ rpcProtocol.ts:402 _receiveRequest @ rpcProtocol.ts:318 _receiveOneMessage @ rpcProtocol.ts:245 (anonymous) @ rpcProtocol.ts:110 fire @ event.ts:622 fire @ ipc.net.ts:468 _receiveMessage @ ipc.net.ts:821 (anonymous) @ ipc.net.ts:660 fire @ event.ts:622 acceptChunk @ ipc.net.ts:241 (anonymous) @ ipc.net.ts:202 I @ ipc.net.ts:32 emit @ events.js:315 addChunk @ _stream_readable.js:295 readableAddChunk @ _stream_readable.js:271 Readable.push @ _stream_readable.js:212 onStreamRead @ internal/stream_base_commons.js:186 console.ts:137 [Extension Host] stack trace: Error: Unknown webview handle:231211bf-3f90-47ef-970c-3065e3e1e663 at Qs.getWebview (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1680:75821) at Qs.$postMessage (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1680:75074) at r._doInvokeHandler (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1687:9767) at r._invokeHandler (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1687:9459) at r._receiveRequest (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1687:8129) at r._receiveOneMessage (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1687:6931) at file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:1687:5040 at l.fire (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:57:1836) at s.fire (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:16135) at i._receiveMessage (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:21385) at file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:18279 at l.fire (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:57:1836) at d.acceptChunk (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:13500) at file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:12848 at Socket.I (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:2760:63309) at Socket.emit (events.js:315:20) at addChunk (_stream_readable.js:295:12) at readableAddChunk (_stream_readable.js:271:9) at Socket.Readable.push (_stream_readable.js:212:10) at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)