search

AlessandroCogollo / SE1-Project-2022

Software Engineering Project - Politecnico di Milano - AA2021/22
2 stars 0 forks source link

pls group common code #15

Closed ingconti closed 2 years ago

ingconti commented 2 years ago

I do appreciate You test:

if (colorId < 0 || colorId > 4)

BUT You call it 4 times.

make a: bool safetyColorCheck(...){ .... if (colorId < 0 || colorId > 4) return false....... }

image

luca-botti commented 2 years ago

Fixed