AlexanderLutsenko
commented
10 months ago the str.removesuffix comes with python 3.9 and add unecessary version constraint
Good find, thanks!
it would be great if the user get an explicit requirements txt
Done.
As for editable install, it's the standard procedure:
git clone https://github.com/AlexanderLutsenko/nobuco.git
pip install -e ./nobuco
Hi, the str.removesuffix comes with python 3.9 and add unecessary version constraint. Please consider switching: all = [basename(f).removesuffix('.py') for f in modules if isfile(f) and not f.endswith('init.py')] to: all = [basename(f)[:-3] if f.endswith('.py') else basename(f) for f in modules if isfile(f) and not f.endswith('init.py')]
In addition the library is not intuitevly compatible with all torch versions (linalg comes starting > 1.17 and _six is depreceated for newer torch versions). it would be great if the user get an explicit requirements txt and add an instruction to installing the library as developper mode (-e . ). Best regards Rayen