Fix render_dim kwarg in test_fps.py by adding color channel dimension.

AlignmentResearch / vlmrm

MIT License

36 stars 11 forks source link

Fix render_dim kwarg in test_fps.py by adding color channel dimension. #2

Closed ScheiklP closed 2 months ago

ScheiklP commented 4 months ago

Just a quick fix for the test_fps.py script.

Rocamonde commented 2 months ago

Hi! Thanks for this. Is it that you found the FPS benchmarking script currently broken? I have not worked on this project for a while, but I do not have the memory of it having any issues.

Regarding the specifics of the PR, seems like most of the diff is changes in code formatting (i.e. line length) - happy to accept the PR (subject to a second review) if you could pick out only the relevant changes that you think are needed to fix the bug.

Thanks again!

ScheiklP commented 2 months ago

Hi @Rocamonde , oh, yeah it was actually just the first commit. I totally forgot that I opened the PR and just pushed new commits to the same branch. Sorry for that!

I will move the unrelated commits to a different branch.

Rocamonde commented 2 months ago

Thanks so much!