AllenInstitute / MIES

Multichannel Igor Electrophysiology Suite
https://alleninstitute.github.io/MIES/user.html
Other
21 stars 6 forks source link

WB: fix recreation of dependent Stimsets from Stimset parameter waves #2063

Closed MichaelHuth closed 3 months ago

MichaelHuth commented 3 months ago

The WB has an issue, where non-existing stimsets are not treated as needing an update. Thus, combine type stimsets that depend on another stimset being created first can not be created because the other stimset is not being created from the parameter waves.

since 792d0d2

close https://github.com/AllenInstitute/MIES/issues/2060

t-b commented 3 months ago

Test failure is unrelated, see

  Dev1: The amount of free disk space on drive "C:" is less than 11GB. Therefore it is not possible to acquire data in MIES.
Please contact your hardware administrator.

I'll fix it.

t-b commented 3 months ago

Fixed.

t-b commented 3 months ago

Review:

MichaelHuth commented 3 months ago

reg. the first point: ST_GetStimsetList retrieves the stimsets defined by parameter waves, I want the saved DA stimsets instead. I check now both.

t-b commented 3 months ago

reg. the first point: ST_GetStimsetList retrieves the stimsets defined by parameter waves, I want the saved DA stimsets instead. I check now both.

Okay, fine with me.

LGTM now. Thanks.