Closed MichaelHuth closed 3 months ago
Test failure is unrelated, see
Dev1: The amount of free disk space on drive "C:" is less than 11GB. Therefore it is not possible to acquire data in MIES.
Please contact your hardware administrator.
I'll fix it.
Fixed.
Review:
GetListOfObjects
obsolete as you can use ST_GetStimsetList
792d0d24d (WB: update stimset on changes, 2016-10-31)
which can be created with git log --pretty=reference -n1 XXX
or the company shortcut git nn XX
. The reason is that short commit hashes are not unique. And you don't immediately see a date. git log
also decided to output more commit hashs characters already, see https://stackoverflow.com/a/21015031 for some explanations.reg. the first point: ST_GetStimsetList retrieves the stimsets defined by parameter waves, I want the saved DA stimsets instead. I check now both.
reg. the first point: ST_GetStimsetList retrieves the stimsets defined by parameter waves, I want the saved DA stimsets instead. I check now both.
Okay, fine with me.
LGTM now. Thanks.
The WB has an issue, where non-existing stimsets are not treated as needing an update. Thus, combine type stimsets that depend on another stimset being created first can not be created because the other stimset is not being created from the parameter waves.
since 792d0d2
close https://github.com/AllenInstitute/MIES/issues/2060