Closed MichaelHuth closed 3 months ago
Review:
d229744c (WB: fix uncaught RTE on initial WB creation, 2024-03-14)
Good find.
a4595827 (AB: Add optional recursive argument to AB_LoadDataWrapper, 2024-03-15)
Nice fix.
735bee09 (AB: fix AB_LoadWave rejecting data if more than one wave is loaded, 2024-03-15)
Yes.
c30d79e1 (STAPI: fix ST_GetStimsetList incorrectly matching against saved stimsets, 2024-03-15)
Very nice history digging!
e7abe693 (NWB: fix Retrieve custom waves from all dependent stimsets, 2024-03-15)
fb43f33e (Tests: Add dep Stimset roundtrip tests through sweep save/load, 2024-03-15)
+ return [setNameB, stimsetList, "root:" + wName, amplitude]
GetWavesDataFolder(wName, 2)
over "root:" + wName
4f2b17f0 (Tests: Add NWB roundtrip tests for combine and custom stimsets, 2024-03-14)
Looks good.
I haven't check but one of tests added later would fail without this fix right?
Yes the test in Tests: Add dep Stimset roundtrip tests through sweep save/load fails without this fix.
@t-b I also changed the description of GetListDifference
because I think it was incorrect.
@t-b I also changed the description of GetListDifference because I think it was incorrect.
Jeep. Thanks.
LGTM.
requires #2063
close #2057 close #2067 close #2068 close #2054