AllenInstitute / MIES

Multichannel Igor Electrophysiology Suite
https://alleninstitute.github.io/MIES/user.html
Other
21 stars 6 forks source link

Add channel dependent samplinginterval #2079

Closed MichaelHuth closed 2 months ago

MichaelHuth commented 3 months ago

part from #1667

requires #2072

close #1938 close #2080

t-b commented 2 months ago

Review:

d2c70965 (LNB: Introduce channel type dependent sampling interval entries, 2024-01-09)

7370fdfc (Util: Change GetSamplingInterval to be channel dependent, 2024-04-05)

        if(IsFinite(dac))
            params.samplingRate     = ConvertSamplingIntervalToRate(GetSamplingInterval(s.DAQConfigWave, XOP_CHANNEL_TYPE_ADC)) * KILO_TO_ONE

ADC -> DAC. If you move the setting of params.channelType above params.samplingRate you can then use

            params.samplingRate     = ConvertSamplingIntervalToRate(GetSamplingInterval(s.DAQConfigWave, params.channelType)) * KILO_TO_ONE

and avoid having to duplicate the channel type constant. Note IPNWB_CHANNEL_TYPE_XXX and XOP_CHANNEL_TYPE_XXX have the same values.

eabfb16f (CTCG: Factor out oodDAQ total xRange determination, 2024-04-05)

Makes sense

5b91e57b (CTCG: Refactor, rename xRange variables to better reflect usage, 2024-04-08)

Okay.

94fb54b6 (CTCG: Calculate correct indices in sweep for display, 2024-04-05)

Nice find.

a9b88a4d (Update IPNWB submodule, 2024-04-08)

Good!

e2d62658 (Tests: Adapt NWBv1 test to check for channel dependent samplingRate, 2024-04-08)

Correct.

5172c1d3 (DC: Do not rely on DAQDataWave for sample interval of scaledDataWave channels, 2024-01-12)

Good!

a4f91e63 (CI: fi ipt-format job not ignoring submodules, 2024-04-08)

Yes!