AllenInstitute / MIES

Multichannel Igor Electrophysiology Suite
https://alleninstitute.github.io/MIES/user.html
Other
21 stars 6 forks source link

Add U_TP_ epochs for PB and AR, Add U_RA_DS, U_RA_UD in epoch recreation #2106

Closed MichaelHuth closed 1 month ago

MichaelHuth commented 2 months ago

close #2074

MichaelHuth commented 1 month ago

One thing I noticed when fixing a ITC vs. NI/SUTTER difference for U_RA_DS is the following: 1. In PSQ_Ramp for ITC hardware as epochEnd for U_RA_DS DimSize(daqDataWave, ROWS) - 1 is used. For ITC this wave is always the next power of two greater than the DA channel wave. As result epochEnd is in all cases beyond the size of the DA channel wave and the epoch gets adjusted after the acquisition through EP_AdaptEpochInfo to DimSize(DAChannel, ROWS). If this is really intended one could just use inf as epochEnd.

2. For NI/SUTTER the end is DimSize(DAChannel, ROWS) - 1 which is in that sense inconsistent with ITC for the same epoch. With the current epoch definition DimSize(DAChannel, ROWS) would make sense, but break compatibility with old data.

t-b commented 1 month ago

Review:

287060291 (Ana: Move U_TP* epoch creation for PB into dev indep function, 2024-05-08)

+1

ef7ea9824 (Ana: Refactor retrieval of expectedNumTestpulses for AR to own function, 2024-05-08)

Makes sense.

bf74312a1 (EPR: Add U_TP epoch recreation for PB and AR, 2024-05-08)

9bd33d482 (Ana: Refactor RA U_RA_DS/U_RA_UD add function to device independent function, 2024-05-08) 208be0b93 (EPR: Add recreation of U_RA_DS user epoch, 2024-05-08) 8e5c4e360 (Tests: Adapt supported user epochs for epoch recreation tests, 2024-05-08)

Makes sense.

a9715eb80 (Ana: Fixed type in user epoch name in documentation, 2024-05-08) e8dc87ab1 (EPR: Add support for U_RA_UD epoch recreation for RA, 2024-05-08) e0ad1fcf4 (Tests: Add U_RA_UD to list of supported user epochs in epoch recreation, 2024-05-08)

Good.

02eb3cb96 (Tests: Add special adaptation for U_RA_UD epochs, 2024-05-10)

Makes sense.

7dbfb2a31 (Ana: Fix U_RA_DS tag name inconsistency between ITC and NI/SUTTER, 2024-05-10)

Nice find!

t-b commented 1 month ago

Typo: "Could not etrieve"