search

AllenInstitute / MIES

Multichannel Igor Electrophysiology Suite
https://alleninstitute.github.io/MIES/user.html
Other
22 stars 6 forks source link

PSQ_DAScale/PSQ_DS_ADAPT: Fix DAScale estimation after fill-in #2241

Closed t-b closed 2 weeks ago

t-b commented 1 month ago

Close #2224

t-b commented 1 month ago

@timjarsky Home-built installer is on the FTP pr-2241.

timjarsky commented 1 month ago

@t-b successful install on rig6, just in time for afternoon experiments. I'll let you know how it goes. Thanks again!

timjarsky commented 1 month ago

@t-b I uploaded AdaptiveSupraExpWithLatestFix.pxp file with several experiments collected with this PR's fix implemented. Some look good, some look odd. We previously identified that we need to enhance the APfrequency operation to have better spike detection, and another experiment where the cell went into depolarization block near the level used to search for spikes in this file confirms that.

t-b commented 1 month ago

Rebased to get CI going again.

t-b commented 3 weeks ago

Data from AdaptiveSupraExpWithLatestFix.zip (Date 4.09.24) has multiple MIES versions used:

  Dbh_Cre_KI_Ai65_751022_08_06_03: Release_2.7_20230809-1011-g87e194ac3
  Dbh_Cre_KI_Ai65_751022_08_06_02: Release_2.7_20230809-1011-g87e194ac3
  Dbh_Cre_KI_Ai65_751022_08_06_01: Release_2.7_20230809-1011-g87e194ac3
  C57BL6J_758777_11_04_02: Release_2.7_20230809-38-g89aadde03
  C57BL6J_758777_11_04_01: Release_2.7_20230809-38-g89aadde03
  C57BL6J_758778_12_04_01: Release_2.7_20230809-1011-g87e194ac3
  C57BL6J_755865_06_02_01: Release_2.7_20230809-969-g1a0233d30
  C57BL6J_755865_06_01_01: Release_2.7_20230809-969-g1a0233d30
  QN24_26_014_16_04A_01: Release_2.7_20230809-1011-g87e194ac3
  Dbh_Cre_KI_Ai65_751029_11_06_01: Release_2.7_20230809-969-g1a0233d30;Release_2.7_20230809-1011-g87e194ac3
  Dbh_Cre_KI_Ai65_751029_11_06_02: Release_2.7_20230809-969-g1a0233d30;Release_2.7_20230809-1011-g87e194ac3

this MR is 87e194ac3 (PSQ_DS_GetValuesOfLargestAPFreq: Only fetch passing data, 2024-08-21).

Mapping from sweepbrowser to experiment:

  Window: SweepBrowser8, Title: Browser [8] , Exp: workFolder:Dbh_Cre_KI_Ai65_751022_08_06_03
  Window: SweepBrowser7, Title: Browser [7] , Exp: workFolder:Dbh_Cre_KI_Ai65_751022_08_06_02
  Window: SweepBrowser6, Title: Browser [6] , Exp: workFolder:Dbh_Cre_KI_Ai65_751022_08_06_01
  Window: SweepBrowser5, Title: Browser [5] , Exp: workFolder:C57BL6J_758778_12_04_01
  Window: SweepBrowser4, Title: Browser [4] , Exp: workFolder:C57BL6J_755865_06_02_01
  Window: SweepBrowser3, Title: Browser [3] , Exp: workFolder:C57BL6J_755865_06_01_01
  Window: SweepBrowser2, Title: Browser [2] , Exp: workFolder:QN24_26_014_16_04A_01
  Window: SweepBrowser1, Title: Browser [1] , Exp: workFolder:Dbh_Cre_KI_Ai65_751029_11_06_01
  Window: SweepBrowser, Title: Browser , Exp: workFolder:Dbh_Cre_KI_Ai65_751029_11_06_02
t-b commented 3 weeks ago

First experiment I'm looking at (arbitrarily selected):

  Window: SweepBrowser5, Title: Browser [5] , Exp: workFolder:C57BL6J_758778_12_04_01;
  C57BL6J_758778_12_04_01: Release_2.7_20230809-1011-g87e194ac3
t-b commented 3 weeks ago

The changes in this PR search the sweep with the highest AP frequency and then fetch it's fitslope/fitoffset/etc. to calculate the next dascale value. But IMHO we should fetch the one with the highset DAScale value.

t-b commented 3 weeks ago

Have a look with fresh again on monday.

t-b commented 3 weeks ago

A set of fresh eyes still say that the change from Friday is good.