search

AllenInstitute / MIES

Multichannel Igor Electrophysiology Suite
https://alleninstitute.github.io/MIES/user.html
Other
22 stars 6 forks source link

GetPossiblePathsToGit() always fails #2268

Open timjarsky opened 4 days ago

timjarsky commented 4 days ago

Description: Create MIES version can't find the git executable because the file paths in GetPossiblePathsToGit() use two semicolons when a single semicolon should be used.

e.g., 

paths[4] = "C::Users:" + userName + ":AppData:Local:Programs:Git:cmd:git.exe"

Additionally, instead of hardcoding the paths, why not use: getenvironmentVariable("PATH")

Igor Pro Experiment/NWB files can be attached as zip file if needed.

The following contains installation information (keep unchanged):

MIES version: Release_2.7_20230809-1072-g831972d85
Date and time of last commit: 2024-09-18T23:33:12+02:00
Submodule status: 
-f7e1cfa52796165f589ab628174a0c4307459b92 Packages/IPNWB
-ecdc0c6271c96ce2101b626b1361ab242a30a2e7 Packages/doc/doxygen-filter-ipf
-b6543f4e52ec0dab137cbe7405e9500bb29a0caf Packages/igortest
Igor Pro version: OS:Microsoft Windows 10 Enterprise (22H2);OSVERSION:10.0.19045.4412;LOCALE:US;IGORFILEVERSION:9.0.6.1;
Installation self-test results:
Checking system properties:
Igor 64bit: 9.06, 56565
Microsoft Windows 10 Enterprise (22H2)
ASLR: False (Nice!)

Checking known defines:
DEBUGGING_ENABLED: No
EVIL_KITTEN_EATING_MODE: No
BACKGROUND_TASK_DEBUGGING: No
THREADING_DISABLED: No

Checking base installation:
Mies version info: Valid "Release_2.7_20230809-1072-g831972d85..." (Nice!)
ITC XOP: Found version 1.0.2.0 (Nice!)
Axon Telegraph XOP: Found version 3.0.0.0 (Nice!)
Multi Clamp Commander XOP: Found version 2.0.0.0 (Nice!)
JSON XOP: Found version 1.0.0.1 (Nice!)
ZeroMQ XOP: Found version 1.0.0.1 (Nice!)
TUF XOP: Found version 1.0.0.1 (Nice!)
MiesUtils XOP: Found version 1.0.0.1 (Nice!)
NWBv2 compound XOP: Found version 1.0.0.1 (Nice!)
JSON XOP: Present in the right version (version-892-g9251933) (Nice!)
ITC2 XOP: Present in the right version (latest-174-gb9915a9) (Nice!)
TUF XOP: Present in the right version (version-163-g686effb) (Nice!)
Results: 10 checks, 0 number of errors

Checking extended installation:
NI-DAQ MX XOP: Found version 1.1.5.0 and hash is not ok (b13267a080053c07b80302212b7f73ac199e1f001d9a1b4303e2d7dce1aeb39e vs 92427feeec9d330d410452b15ff1b6da90fe8e2dd0b8362cd711358c8726706a) (Very Bad)
Results: 1 checks, 1 number of errors
Available NI devices with their properties:
Device name: NI6343
#AI 32, #AO 4, #Cnt 4, #DIO ports 3 with (32,8,8) lines
Last self calibration: 2023-10-03T11:11:00Z
Last external calibration: 2017-12-17T02:07:00Z
Device name: PressureDAC
#AI 8, #AO 2, #Cnt 1, #DIO ports 3 with (32,8,8,8,4,1) lines
Last self calibration: na
Last external calibration: 2016-02-16T07:11:00Z
t-b commented 4 days ago

I've added a fix.

Additionally, instead of hardcoding the paths, why not use: getenvironmentVariable("PATH")

On Windows you can install git without it being in PATH. So I figured it is not worth the hassle.

timjarsky commented 3 days ago

I've added a fix.

Additionally, instead of hardcoding the paths, why not use: getenvironmentVariable("PATH")

On Windows you can install git without it being in PATH. So I figured it is not worth the hassle.

@t-b It would have prevented this bug, tho.

t-b commented 3 days ago

Okay ;) let's try plain git as fallback. We don't need to check PATH as this is done for us.