Alvi-alvarez / sd-Img2img-batch-interrogator

Img2img batch interrogator for AUTOMATIC1111's Stable Diffusion web UI
MIT License
18 stars 3 forks source link

Additional Interrogator, AlwaysVisible and Experimental (Fun) Tools Update #10

Closed SmirkingKitsune closed 1 month ago

SmirkingKitsune commented 2 months ago

This update implements a new set of features to improve the interrogations of img2img interrogations. Now additional interrogators from A1111 extensions can be used to interrogate images. Additionally, I added some UI cleanup to keep from over cluttering the UI. This should also resolve issue #9.

New Interaction Suite: Changed in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/1f8d5373503c2c5f77ab476934180e1813b2fe33.

UI Overhaul:

Bug Fixes:

Special Notes:

SmirkingKitsune commented 2 months ago

~~BIG IMPORTANT SPECIAL NOTE: Since this uses the API, it might require the --api command argument to be declared at runtime.~~ No longer matters as of https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/1f8d5373503c2c5f77ab476934180e1813b2fe33.

SmirkingKitsune commented 2 months ago

Supplementary note:

SmirkingKitsune commented 2 months ago

The purpose of https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/6b1b47f3929bfebeffecf2f81dcf9d494f6e726d is so that this script can be run alongside any other script one might want to use in img2img. By making this a AlwaysVisible element on the img2img tab, the script dropdown can select other scripts. Such as in the case of using outpainting or text matrix, but still wanting to interrogate the imported images. Removed pending bug investigation in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/commit/b7f1440367a332d696dd4e217ab3d54f6e5677cf

SmirkingKitsune commented 2 months ago

There is a severe bug in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/commit/6b1b47f3929bfebeffecf2f81dcf9d494f6e726d

SmirkingKitsune commented 2 months ago

Always Visible is the source of the bug. Always Visible functions was rolled back in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/b7f1440367a332d696dd4e217ab3d54f6e5677cf pending further investigation.

SmirkingKitsune commented 2 months ago

Major overhaul to this patch. I was unsatisfied with the performance and restraints that working through the API caused. So API has been removed in favor of direct extension interactions.

Updated initial pull request comment to reflect these changes.

Pawelekkkkk commented 2 months ago

Thank you. I will test it as soon as I will be at home. I really appreciate.

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/8bc9ece0ec128659ba53deac0292fa5aadabcab5

SmirkingKitsune commented 2 months ago

There is a known quirk with the model_selector, where the models "CLIP (EXT)" and "WD (EXT)" will still appear the first time users click on the model_selector drop down menu, even if the associated extensions are not installed or enabled. The options will not be selectable if associated extensions are not installed or enabled. The options will disappear the 2nd time the user opens up the model_selector drop down menu.

Attempted Fixes:

Since the options are not selectable, it is not dangerous to runtime. Since the associated options disappear after the update_model_choices is called after first menu click, it is self correcting. Further investigation required to resolve this quirk. Fixed as of https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/b3743e43b22c6d45abdf5b1bff46861a0f2266df

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/b3743e43b22c6d45abdf5b1bff46861a0f2266df to resolve model_selector quirk:

SmirkingKitsune commented 2 months ago

Notes on https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/17b11276b0dcd91c8542ac661ab238d52a81eb5d for bug fix:

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/250d912fc0a360e7b2d819f5f932a964c0a4a0c2:

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/82aa96f3f0b54c6312fe635661c8510ae55dc0e2:

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/1a423bf1dc06c04633c47d270c64f7aabc0e07b9:

SmirkingKitsune commented 2 months ago

There were a lot of things that needed to be changed to get AlwaysVisible to work correctly and as expected. Along the way, I implemented some tools that I thought would be fun or interesting.

Converted Script for AlwaysVisible Use.

Experimental Tools:

Changes to Filter:

Other Changes:

Special Notes:

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/edec8720f1d1a1e535b4abbe3e86a615e1e739c4:

SmirkingKitsune commented 2 months ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/50bcbb886811cc3a3841d2c97724143690cef303:

SmirkingKitsune commented 1 month ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/919f4cfb31493c92a731068988435199590f58e5:

SmirkingKitsune commented 1 month ago

Changes in https://github.com/Alvi-alvarez/sd-Img2img-batch-interrogator/pull/10/commits/60bc36d5d9525f447a98bb0f4fc6587e547322fb: