Closed KELSEYDOWLING7 closed 1 month ago
I do need to leave at 2:30 today to catch a flight. Feel free to update the issue whenever finish, and I will double check on Monday to see what, if anything, needs to be run manually
Ok! Thanks for making the checklist. Were you able to push the Ops report again after the merge went awry?
Np! I wasn't, though I wasn't sure if that was needed. It looks like the code on the main branch matches what I have locally
Ok! Sounds good. I wasn't sure about that either. I plan to start testing at ~2pm
Sounds good!
@KELSEYDOWLING7 The Weekly Module Metrics failed.
@KELSEYDOWLING7 The Weekly Biospecimen Report failed.
Thanks Jake, it looks like somehow both of those had a merge conflict, specifically that those chunk were entered twice in GCP but not in my local files. I'll try doing a new PR.
The Metrics report had some other changes recently, so hopefully the full new PR works. The Biospecimen report hasn't changed, so if the PR doesn't work we'll have to do a direct edit on the main branch in GCP
I'll rerun the reports locally and post them to Box though for today so don't worry about that part
If you have time, it wouldn't hurt to test these too, though I'm pretty confident that the changes are minor enough not to cause any issues