AndrewEllis93 / Ellis-SuperSlicer-Profiles

752 stars 167 forks source link

typo in before_layer_change gcode #2

Closed kesor closed 2 years ago

kesor commented 2 years ago

Both in the screenshot image and in the profile ini file you have an extra 0 in the layer change gcode.

; External perimeter
{if extrusion_role=~/ExternalPerimeter/};[extrusion_role]0
AndrewEllis93 commented 2 years ago

Thanks! Fixed it. I wonder if that's related to some issues people have been having with the post processing script - though it's working for me.

On Tue, Oct 19, 2021 at 5:01 AM Evgeny Zislis @.***> wrote:

Both in the screenshot image and in the profile ini file you have an extra 0 in the layer change gcode.

; External perimeter {if extrusion_role=~/ExternalPerimeter/};[extrusion_role]0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AndrewEllis93/Ellis-PIF-Profile/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKTBUX2WG2T37AP5HCUL43UHUXVFANCNFSM5GITCIPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Andrew Ellis (757) 615-4955

kesor commented 2 years ago

Actually, I am pretty much sure that this is unrelated to anything. Since it just adds a new line that starts with ; and that is a comment line ...

In my own configuration I moved all the comment lines to be inside the conditions, which I believe results in a slightly smaller g-code (one line less of gcode comments).

feature_gcode = {if extrusion_role =~ /ExternalPerimeter/}\n; Extrusion Role: External perimeter\nSET_VELOCITY_LIMIT ACCEL=1000 ACCEL_TO_DECEL=1000 SQUARE_CORNER_VELOCITY=8\n{elsif e
xtrusion_role=~/Perimeter/}\n; Perimeter\nSET_VELOCITY_LIMIT ACCEL=2000 ACCEL_TO_DECEL=2000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/OverhangPerimeter/}\n; Extrusion Role: O
verhang perimeter\nSET_VELOCITY_LIMIT ACCEL=2000 ACCEL_TO_DECEL=2000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/InternalInfill/}\n; Extrusion Role: Internal infill\nSET_VELOCI
TY_LIMIT ACCEL=5600 ACCEL_TO_DECEL=7000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/TopSolidInfill/}\n; Extrusion Role: Top solid infill\nSET_VELOCITY_LIMIT ACCEL=2000 ACCEL_TO
_DECEL=2000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/SolidInfill/}\n; Extrusion Role: Solid infill\nSET_VELOCITY_LIMIT ACCEL=4000 ACCEL_TO_DECEL=4000 SQUARE_CORNER_VELOCITY=
8\n{elsif extrusion_role=~/BridgeInfill/}\n; Extrusion Role: Bridge infill\nSET_VELOCITY_LIMIT ACCEL=5000 ACCEL_TO_DECEL=5000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/GapFil
l/}\n; Extrusion Role: Gap fill\nSET_VELOCITY_LIMIT ACCEL=2000 ACCEL_TO_DECEL=2000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/Skirt/}\n; Extrusion Role: Skirt\nSET_VELOCITY_LI
MIT ACCEL=7000 ACCEL_TO_DECEL=7000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/SupportMaterial/}\n; Extrusion Role: Support material\nSET_VELOCITY_LIMIT ACCEL=7000 ACCEL_TO_DEC
EL=7000 SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/SupportMaterialInterface/}\n; Extrusion Role: Support material interface\nSET_VELOCITY_LIMIT ACCEL=7000 ACCEL_TO_DECEL=7000
SQUARE_CORNER_VELOCITY=8\n{elsif extrusion_role=~/ThinWall/}\n; Extrusion Role: Thin walls\nSET_VELOCITY_LIMIT ACCEL=2000 ACCEL_TO_DECEL=2000 SQUARE_CORNER_VELOCITY=8\n{else}\n; Extr
usion Role: Other\nSET_VELOCITY_LIMIT ACCEL=4444 ACCEL_TO_DECEL=4444 SQUARE_CORNER_VELOCITY=8\n{endif}