search

AndrewRadev / vimrunner

Control a vim instance through ruby code
MIT License
238 stars 13 forks source link

Kill Vim instance on script exit or not? #20

Open AndrewRadev opened 11 years ago

AndrewRadev commented 11 years ago

As discussed in https://github.com/AndrewRadev/vimrunner/pull/19, there's a lot of sense in providing an option to keep the spawned Vim around after the script has exited. Currently, this works with the :foreground => false option for gvim. It might be a good idea to look into providing similar functionality for headless vim. I also think it might make more sense to have a separate method instead to detach the vim instance from the spawning script.

moll commented 11 years ago

That's possibly not a good idea to do automatically. Given that it's most likely to happen via at_exit, it might introduce race conditions if some code, like some test runners today do, runs in an at_exit block. It'll fail if Vimrunner exits in an at_exit prior to that.

AndrewRadev commented 11 years ago

The Vim instance will be killed automatically upon process exit, since it's a child of that process (as far as I know). The issue discussed in #19 was whether we should make some way to detach the child process, so it stays behind after the script had finished. I don't think using at_exit would be necessary, unless I'm missing something.

moll commented 11 years ago

Aah, got it. And it does get killed as a child at the moment.