search

AndrewRadev / vimrunner

Control a vim instance through ruby code
MIT License
238 stars 13 forks source link

Remove duplication in Server, fix rescues #36

Closed alexgenco closed 10 years ago

alexgenco commented 10 years ago

Process.kill(0, @pid) rescue Errno::ESRCH will rescue all exceptions (and then return the class Errno::ESRCH). You need a multiline begin-rescue-end to rescue only a particular exception.

alexgenco commented 10 years ago

This is failing because travis is using RSpec 3. I'm guessing RSpec 3 was released after the last time ci was run. https://github.com/AndrewRadev/vimrunner/pull/35 should fix it then.

AndrewRadev commented 10 years ago

I don't know what I was thinking with that one :). Good catch, thanks. I'll check the travis build after the merge.