AndreyMrovol / LethalWeatherTweaks

Changes to weather system in Lethal Company.
https://thunderstore.io/c/lethal-company/p/mrov/WeatherTweaks/
Other
3 stars 0 forks source link

Very minor WeatherTweaks nitpcik #32

Open Skittlekirby opened 6 days ago

Skittlekirby commented 6 days ago

Hey,

Love the mod and the life it brings to the game. This is a pretty small complaint, but when weather displays as XYZ -> Rainy, there's immediately quicksand on the moon in different spots before the weather technically transitions to rainy.

I of course think that makes sense; it would be bizarre/frustrating to be walking and suddenly end up in the center of quicksand. It just has confused multiple different groups of friends because they don't think that way, they see stormy -> rainy and get upset at the sand immediately outside the ship.

Would it be possible to prevent rainy from being a second variable to shift into, or just outright always display it as an additional weather variable rather than a transitioning one when it does generates that way?

I hope what I'm saying makes sense. It's maybe the smallest nitpick that could be found in a mod and I understand the low-prio behind it. Just leaving some thorough feedback. Thanks for the mod :)

AndreyMrovol commented 6 days ago

Hey, thanks for voicing your opinion - I agree that the current solution is a poor compromise. Here's how it works under the hood:

https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/52a386fe2c2eda9fadeb3ed0d4c1954a423e048f/WeatherTweaks/Patches/SpawnOutsideHazards.cs#L30-L37

https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/52a386fe2c2eda9fadeb3ed0d4c1954a423e048f/WeatherTweaks/Variables.cs#L282-L290

https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/52a386fe2c2eda9fadeb3ed0d4c1954a423e048f/WeatherTweaks/Definitions/ProgressingWeather.cs#L124-L127

I'm changing the vanilla check for Rainy weather to allow spawning quicksand when one of the present weathers is Rainy, which - in case of progressing weathers (such as Stormy -> Rainy) checks for all possible weathers during the day.

I can think of a few solutions for this issue: