Due to the transfer, the weather in the terminal is not the same

AndreyMrovol / LethalWeatherTweaks

Changes to weather system in Lethal Company.

https://thunderstore.io/c/lethal-company/p/mrov/WeatherTweaks/

Other

3 stars 0 forks source link

Due to the transfer, the weather in the terminal is not the same #5

Closed Paradox75831004 closed 5 months ago

Paradox75831004 commented 5 months ago

I'm not sure exactly, but because of the translation, it shows the exact weather and it doesn't matter what the weather is written on the monitor...

I think the problem is on my side that I have installed too many mods

018d7d8c-7252-8a67-8364-fd87914208f4

AndreyMrovol commented 5 months ago

Hey, thanks for reporting the issue - I'm gonna check what's happening.

AndreyMrovol commented 5 months ago

From what i've found:

Info screen shows true weather because of CorporateRestructureWeather - this is a functionality that's included with my mod (colored weather display)
Terminal shows prices because of MoonsPriceDisplay, which overrides LLL (and my mod) from inserting custom weathers into the list (https://github.com/Gloveman23/MoonPriceDisplay/blob/9b53f795c762fec30a3dc33242b7bb360e6ebc7b/Plugin.cs#L63)
Russian translation mods completely override LLL's terminal display, and my mod won't display its weathers because of it (unfortunately)
GeneralImprovements monitor always display true weather (in your case monitor 1 and 2)

Disabling these mods allowed uncertain weathers to show up.

Paradox75831004 commented 5 months ago

I thought so, thanks for the explanation. Will this be fixed in the future? Or just disable mods and play without them...

Paradox75831004 commented 5 months ago

I've just been looking for a very long time for a mod that somehow hid the weather, allows you to complicate the gameplay and make forays into different weather more often

AndreyMrovol commented 5 months ago

Hey, I'll see what I can do, but the translation mod inserts itself in such a way that my mod isn't even executed:

AndreyMrovol commented 5 months ago

Okay, I think i managed to find the issue and how to solve it: RTLC Russian Translation Mods patches LoadNewNode method as a prefix (code snippet).name%2C%20node.displayText)%3B%0A%09%09%09if%20(text%20!%3D%20null)%0A%09%09%09%7B%0A%09%09%09%09node.displayText%20%3D%20text%3B%0A%09%09%09%7D%0A%09%09%09return%20true%3B%0A%09%09%7D), which skips LethalLevelLoader's method in its entirety, causing no modded weathers to show up.

When I've manually unpatched this, all modded weathers (and their translations) showed up, but the translations were mostly broken.

Moreover, I saw that this is a wider issue with translation mod as a whole (example).

@Paradox75831004 Could you get in contact with translation mod's author and suggest changing Prefix to Postfix method? I think this wouldn't break translations and it would make my (and many other) mods compatible.

AndreyMrovol commented 5 months ago

I've attemted some fixes on my end:

this mod will always replace vanilla's [planetTime] placeholder with empty string
this mod's SetMapScreenInfoToCurrentLevel patch has the highest priority, so it will override other mods trying to apply the same functionality.