search

AndyReifman / ArseneWenger

1 stars 12 forks source link

Switch from requests to aiohttp #63

Closed FelixRandle closed 2 years ago

FelixRandle commented 2 years ago

The requests library isn't asynchronous so on longer requests it blocks operation of the bot whilst the request is being handled

Should switch over to aiohttp which fully supports async/await

ash663 commented 2 years ago

If we do switch over to aiohttp, we should do it safely. There's a decent chance people will abuse the bot by spamming commands and opening up multiple threads can bring down the server. We need some sort of loadshedding in the bot and decide on the maximum number of threads we want open at any point of time

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.