search

AntelopeIO / abieos

Other
2 stars 12 forks source link

abieos_bin_to_json(): ignore trailing garbage in the stream #18

Closed cc32d9 closed 1 year ago

cc32d9 commented 1 year ago

this fixes https://github.com/AntelopeIO/abieos/issues/12

spoonincode commented 1 year ago

The fix seems clearly correct, but is there any concern about breaking existing behavior? Is there any possibility someone was relying on the old behavior to verify.. something? (I'm having a hard time imagining a use case)

cc32d9 commented 1 year ago

chronicle is actively using the library. Fill-pg was using it too, but it's not maintained as far as I know. The issue was that a contract accepted an action, but we cannot read that properly from the state history. I doubt anyone relied on that, and this error was pretty difficult to spot.

stephenpdeos commented 1 year ago

@cc32d9 since this has been approved by two qualified reviewers it can be merged if you'd like to do the honors. Please reach out if you have any questions on process.