AntelopeIO / abieos

Other
2 stars 12 forks source link

bump rapidjson submod to newer version to avoid c++20 warnings #21

Closed spoonincode closed 1 year ago

spoonincode commented 1 year ago

On some newer clang compilers I'm seeing a warning when compiling in c++20,

leap/tests/abieos/external/rapidjson/include/rapidjson/document.h:813:58: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'rapidjson::GenericValue<rapidjson::UTF8<>>::MemberIterator' (aka 'rapidjson::GenericMemberIterator<false, rapidjson::UTF8<>, rapidjson::MemoryPoolAllocator<>>') and 'rapidjson::GenericValue<rapidjson::UTF8<>>::MemberIterator') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]
                for (MemberIterator m = MemberBegin(); m != MemberEnd(); ++m)

Bumping to the latest rapidjson master resolves the issue & abieos' ctest passes. rapidjson does not appear to make release tags any longer, so the presumption is master is clean (the prior submoduled version of rapidjson in abieos is also just at some arbitrary point in time on rapidjson's master)

spoonincode commented 1 year ago

I reworded it a bit