search

AntiEvictionBoston / Maps

Maps highlighting eviction and displacement in Boston, using leaflet.js and React.
GNU Affero General Public License v3.0
6 stars 0 forks source link

Facebook video component shows same video over and over #51

Closed heybenji closed 8 years ago

heybenji commented 8 years ago

@aliceriot this is a showstopping bug -- do it first.

As far as I can tell, whenever a video gets loaded in the story panel, it doesn't get replaced by the next video.

Also, if you go to a story with no video but an image or images, then navigate backwards to a pin with a video, it doesn't appear.

alicewriteswrongs commented 8 years ago

ugh this is really tricky trying to force react to totally blow away the DOM node when a new prop gets passed in

alicewriteswrongs commented 8 years ago

really out of my depth here T_T

I'm not sure exactly what's going on, react updates the wrapping component but everything I've tried to do to get the video to reload doesn't work.

resourcing the SDK every time doesn't work, blowing away innerHTML doesn't work, raaaaa

alicewriteswrongs commented 8 years ago

I can't find anything useful about facebook videos in react either

i really need to leave for work now but I think I can work on this more during the day

heybenji commented 8 years ago

HF is uploading the vids to youtube. Their iframe-based implementation may be kinder to what we're trying to do.

Thoughts? And thanks for trying to fix.

On Mar 14, 2016, at 8:42 AM, Alice notifications@github.com wrote:

I can't find anything useful about facebook videos in react either

i really need to leave for work now but I think I can work on this more during the day

— Reply to this email directly or view it on GitHub.

alicewriteswrongs commented 8 years ago

OK I'll go back to the YouTube component.

There's a react component for embedding YouTube videos which seems to work well (was using it before) I think we should give that a try.

If we want to do that we should change the video fields on the data to be the unique ID for YouTube videos (the hash-ey looking thing in the URL) On Mar 14, 2016 9:13 AM, "Benji Mauer" notifications@github.com wrote:

HF is uploading the vids to youtube. Their iframe-based implementation may be kinder to what we're trying to do.

Thoughts? And thanks for trying to fix.

On Mar 14, 2016, at 8:42 AM, Alice notifications@github.com wrote:

I can't find anything useful about facebook videos in react either

i really need to leave for work now but I think I can work on this more during the day

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/AntiEvictionBoston/Maps/issues/51#issuecomment-196305022 .

heybenji commented 8 years ago

Hey @aliceriot I think we're basically ready to pull the switch to YouTube in the next hour if you can revert. I might also be able to do a manual cherry pick of stuff based on your commit history, but I'd rather you do it if you can spare the time today.

I'm going to start a pull request for just changing the video URLs and leave it unmerged.

alicewriteswrongs commented 8 years ago

Great I can take care of this soon. On Mar 14, 2016 10:28 AM, "Benji Mauer" notifications@github.com wrote:

Hey @aliceriot https://github.com/aliceriot I think we're basically ready to pull the switch to YouTube in the next hour if you can revert. I might also be able to do a manual cherry pick of stuff based on your commit history, but I'd rather you do it if you can spare the time today.

I'm going to start a pull request for just changing the video URLs and leave it unmerged.

— Reply to this email directly or view it on GitHub https://github.com/AntiEvictionBoston/Maps/issues/51#issuecomment-196332701 .

heybenji commented 8 years ago

Fixed by #63