search

AntonioDePau / GHDS_ModdingTool

Modding tool for GH and BH on NDS
6 stars 0 forks source link

Some midi files fail to import #24

Open generalguy26 opened 6 months ago

generalguy26 commented 6 months ago

v.1.0.5

To reproduce:

  1. Export a chart as a midi file in Moonscraper, or convert a chart to midi using Chart2Mid (https://www.scorehero.com/forum/viewtopic.php?p=985829)
  2. Attempt to import the chart

The tool seems to work fine on midi files from the rock band converts, but editing them in Moonscraper and exporting them breaks it.

Error: image

Files I used that caused it: llama.zip

AntonioDePau commented 6 months ago

Note to myself:

Either pass fewer tracks here: https://github.com/AntonioDePau/GHDS_ModdingTool/blob/main/gh/charts/charts.cs#L380-L385 Or here (and use the track list instead of set tracks): https://github.com/AntonioDePau/GHDS_ModdingTool/blob/main/gh/charts/midi/midi.cs#L184

Or simply check if the track is null and skip it here: https://github.com/AntonioDePau/GHDS_ModdingTool/blob/main/gh/charts/midi/midi.cs#L260