Antti / rust-amqp

AMQP client in pure rust. Corresponds to rabbitmq spec.
MIT License
247 stars 45 forks source link

Implement connection heartbeating. #66

Open thedodd opened 6 years ago

thedodd commented 6 years ago

open questions

Heartbeats are great, and are working as of this PR; however, until we implement an auto-reconnect algorithm, heartbeats are not super effective. Do we want to include an auto-reconnect implementation here as well? Or does it suffice to simply close the underlying TCP connection for now?

TODO:

Should close #50.

gagath commented 6 years ago

Hey, I am interested in this change. What is the status of it?

andir commented 6 years ago

I started resolving some of @Antti's and my comments in my fork.

https://github.com/andir/rust-amqp/commits/heartbeat

Feel free to cherry-pick them into this PR.

thedodd commented 6 years ago

@andir @MicroJoe @Antti hey all, just wanted to reach out since I haven't moved on this PR for a while.

I actually ended up going with a different AMQP lib for the stuff I was hacking on at the time. I needed futures based async as opposed to threading and such.

@andir sounds like you have forked and have made some progress. That's awesome! Please feel free to open a PR which supersedes this one. I don't think I will have the time to address some of the deeper issues I was concerned with here.

@Antti feel free to close this PR whenever you would like. I'll leave it open until I hear back from @andir on what their plans are for moving forward with the fork.

Thanks all!