search

Antti / rust-amqp

AMQP client in pure rust. Corresponds to rabbitmq spec.
MIT License
247 stars 45 forks source link

Upgrade to the latest openssl #75

Open alex opened 5 years ago

alex commented 5 years ago

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.

I wasn't sure what to do about the impl Clone on connection, there doesn't appear to be a way to get the current behavior with SslStream in the latest version of openssl.

Shnatsel commented 5 years ago

Relevant to #58

dizda commented 5 years ago

LGTM 👍

Antti commented 5 years ago

This doesn't really upgrade to the latest openssl, as adding panic makes it TLS mode completely non-functional. I removed tls feature from the list of default features, this should make it easier to use this crate when the tls (openssl) feature is not required.

alex commented 5 years ago

Hmm, unfortunately I don't believe it's possible to emulate the Clone API with a recent OpenSSL, except perhaps by making it an Rc (or maybe Arc or Mutex + Arc). Do you have an opinion on how to proceed?