Closed NiChrosia closed 3 years ago
did you seriously-
mods
No, don't disable orbits, but allow having planets orbit other planets, including themselves if needed to be static
I never said disable orbits
I don't know the source code that well, but I think preventing updatePlanet from modifying the position of the planets (which is what moving is) would break orbits
updatePlanet
is only called for the sun at the moment, and not any children of it.
This suggestion is now stale, and will be automatically closed.
Describe the content or mechanics you are proposing.
Make
Universe#updatePlanet
not modify the position of the planet, to allow custom solar systems, as well as a new variable inPlanet
to denote it being the root of a solar system.Universe#updateGlobal
would also useVars.content.planets().copy().filter(p -> p.isRoot).forEach(p -> updatePlanet(p));
, rather than justupdatePlanet(Planets.sun)
Describe how you think this content will improve the game. If you're proposing new content, mention how it may add more gameplay options or how it will fill a new niche.
It would allow modders to separate their content from vanilla's in a more distinct way.
Before making this issue, place an
X
in the boxes below to confirm that you have acknowledged them. Failure to do so may result in your request being closed automatically.README.md
to make sure my idea is not listed under the "A few things you shouldn't suggest" category.