Anuken / Mindustry-Suggestions

Repository for Mindustry suggestions and feedback
128 stars 58 forks source link

Moddable solar systems #2733

Closed NiChrosia closed 3 years ago

NiChrosia commented 3 years ago

Describe the content or mechanics you are proposing.

Make Universe#updatePlanet not modify the position of the planet, to allow custom solar systems, as well as a new variable in Planet to denote it being the root of a solar system. Universe#updateGlobal would also use Vars.content.planets().copy().filter(p -> p.isRoot).forEach(p -> updatePlanet(p));, rather than just updatePlanet(Planets.sun)

Describe how you think this content will improve the game. If you're proposing new content, mention how it may add more gameplay options or how it will fill a new niche.

It would allow modders to separate their content from vanilla's in a more distinct way.

Before making this issue, place an X in the boxes below to confirm that you have acknowledged them. Failure to do so may result in your request being closed automatically.

    • [X] I have checked the Trello to make sure my suggestion isn't planned or implemented in a development version.
    • [X] I am familiar with all the content already in the game or have glanced at the wiki to make sure my suggestion doesn't exist in the game yet.
    • [X] I have read README.md to make sure my idea is not listed under the "A few things you shouldn't suggest" category.
SMOLKEYS commented 3 years ago

did you seriously-

QmelZ commented 3 years ago

mods

Bottinator22 commented 3 years ago

No, don't disable orbits, but allow having planets orbit other planets, including themselves if needed to be static

NiChrosia commented 3 years ago

I never said disable orbits

Bottinator22 commented 3 years ago

I don't know the source code that well, but I think preventing updatePlanet from modifying the position of the planets (which is what moving is) would break orbits

NiChrosia commented 3 years ago

updatePlanet is only called for the sun at the moment, and not any children of it.

github-actions[bot] commented 3 years ago

This suggestion is now stale, and will be automatically closed.