search

AppImage / appimagetool

A low-level tool to generate an AppImage from an existing AppDir
58 stars 11 forks source link

Release static binaries only #12

Closed TheAssassin closed 1 year ago

TheAssassin commented 1 year ago

Fixes #1.

TheAssassin commented 1 year ago

@probonopd static binaries for libassuan are not available for arm, apparently, but only for x86_64/i686. Could you open another issue, please?

probonopd commented 1 year ago

https://gitlab.alpinelinux.org/alpine/aports/-/issues/15054

TheAssassin commented 1 year ago

It won't save any significant amount of space, but comes at the cost of reduced debuggability. I don't see any point in doing so. I'd rather review what we are linking against first.

By the way, I would not recommend stripping any of the binaries either.

probonopd commented 1 year ago

Answer by alice upstream regarding the missing ARM builds:

that's because the arm builders are/were offline, but it will be there when they come back

It seems like the ARM builders have been down since ~ a week. Hopefully will be back soon.

Shall we just comment out the ARM builds in the meantime?

TheAssassin commented 1 year ago

We have no pressure, really, do we? I don't mind keeping this open for another week. AppImageKit is still up and running, and nobody's using this repository as of yet.

TheAssassin commented 1 year ago

Just tried, ARM packages for libassuan-static are available now. I'll restart the CI.

Edit: GitHub disagress, at least for AArch64. Let's retry later again.

TheAssassin commented 1 year ago

Please do not unexpectedly merge PRs. I just found a regression.

TheAssassin commented 1 year ago

Note: regression only affects AppImageLauncher and is likely due to the runtime itself, not appimagetool's now-static AppImage. The AppImage works fine without AppImageLauncher. I'll open an issue in the right place once I know what the problem is.