search

AppImage / appimagetool

A low-level tool to generate an AppImage from an existing AppDir
58 stars 11 forks source link

Don't build twice in pull requests #21

Closed probonopd closed 1 month ago

probonopd commented 12 months ago

type2-runtime is already doing it like this.

TheAssassin commented 12 months ago

This could be called "force user to create PR to get builds". I'm not really a fan of this. In what way is this needed? We have enough free runner slots so this won't save build time.

probonopd commented 12 months ago

It saves a lot of energy and hence presumably CO2.

TheAssassin commented 12 months ago

It saves a lot of energy and hence presumably CO2.

It can. But detecting problems early can save more of this. This is a straw man fallacy IMO. I'm not aware of any studies.

probonopd commented 12 months ago

I'd still be in favor of this. Its also cleaner and simpler visually in the PRs.

probonopd commented 1 month ago

https://github.com/AppImage/type2-runtime/pull/28 is the opposite of this, so maybe we should not merge this PR?

TheAssassin commented 1 month ago

pull_request tests a potential merge conflict. push builds the branch as it would build main. Both serve separate purposes. Especially when working with CI changes, push is absolutely needed to be able to evaluate what is going on. I don't think it makes a lot of sense to add extra work and make a temporary commit every time one needs to test such a change like done recently while working on the type 2 runtime. Closing therefore.

TheAssassin commented 1 month ago

What a coincidence. Yes, I think this should be closed.