Closed TheAssassin closed 12 months ago
Accidentally pushed https://github.com/AppImage/appimagetool/commit/810916a858d5d23a03764daf872fc60538813069 directly to master, which implements this change. Please feel free to do a post-merge review. Sorry.
Currently, when
--comp
is not passed to appimagetool, we callmksquashfs
without its-comp
parameter, falling back tomksquashfs
's default compression (which is configured at its build time). We also show a warning that we fall back to the default. This is for users of the tool which do not use the officially provided AppImages, but build their own version (using custom builds ofmksquashfs
etc., too).This is not a great UX. To improve the situation, we decided to just pass
-comp zstd
if--comp
is not provided, makingmksquashfs
either use it as intended, or print a meaningful error message that this compression is not available. Users who need to use a build ofmksquashfs
that does not support-comp zstd
can then fix the situation either by providing a proper build of this tool or manually passing the name of an alternative compression algorithm likexz
(our old default).