Implement certificate lookup, closes #24

AppImage / appimagetool

A low-level tool to generate an AppImage from an existing AppDir

58 stars 11 forks source link

Implement certificate lookup, closes #24 #29

Closed probonopd closed 12 months ago

probonopd commented 12 months ago

Tested on openSUSE.

Use SSL_CERT_FILE and/or SSL_CERT_DIR environment variables if set, otherwise check for common locations
Do not check certificates if APPIMAGETOOL_FETCH_RUNTIME_INSECURE is set

References:

https://curl.haxx.se/docs/sslcerts.html
https://gitlab.com/probono/platformissues#certificates
https://go.dev/src/crypto/x509/root_linux.go

probonopd commented 12 months ago

Tested successfully on openSUSE Leap 15.5

TheAssassin commented 12 months ago

See #32 for an alternative implementation. This alternative version does not support the environment variables proposed in this PR. In my opinion, it is a viable workaround to require from users to manually download the runtime if the TLS validation fails. And if it's a bug, we want to motivate them to create an issue this way.

probonopd commented 12 months ago

Closing in favor of #32