Appsilon / data.validator

validate your data and create nice reports straight from R
https://appsilon.github.io/data.validator/
Other
147 stars 14 forks source link

[Bug]: app crashes after 'show' on render_semantic_report_ui #52

Closed dannyvolkaerts closed 1 year ago

dannyvolkaerts commented 1 year ago

Guidelines

Project Version

4.1.2

Platform and OS Version

Windows

Existing Issues

No response

What happened?

After updating a tremendous number of packages (xfun,vctrs,..) in R-4.1.2 the data.validator package is not working in shiny (shiny version 1.7.1). The report variable is created correct but as soon as I ask in shiny to "show" the errors, the shiny app crashes without warning or error message in console.. No idea how to tackle it

Steps to reproduce

  1. Easy: I just tried to run the shiny example on the data.validator github page

Expected behavior

to show the errors according to the validation rules I set

Attachments

No response

Screenshots or Videos

No response

Additional Information

No response

jakubnowicki commented 1 year ago

@dannyvolkaerts, the most probable is that the problem was related to an issue with CDN that serves shiny.semantic assets. Please check again - it should work now.

dannyvolkaerts commented 1 year ago

@jakubnowicki Thank you for the fast reply. The application indeed works now for the 'show' feature. However I cannot expand or close the 'Failed' or 'Passed' rules tab (don't know if it worked before).

jakubnowicki commented 1 year ago

@dannyvolkaerts this bug is already fixed in the development version available on GitHub. We plan to release it on CRAN within a month.

dannyvolkaerts commented 1 year ago

Super! Thank you very much! Case closed.