[Enhancement] Move icon redefinitions from data-final-fixes to data/data-updates where possible

kirazy commented 3 years ago

There are a number of icons that are set by smelting/petrochem via data-final-fixes requires and overrides. As bobplates is finished constructing items in data, data-updates at the latest, I'm unclear as to the rationale for having these done in data-final-fixes.

It would be greatly appreciated if icon assignments and redefinitions could be finished prior to data-final-fixes, where possible. And in most cases it should be possible.

Icon overwrites of this nature need to be done as early as possible so that other mods that scrape recipes, items, and create derivative items can create correct icons without complicated dependency chains.

Detailed breakdown: angelssmelting

base: iron/copper/steel/wire
bobplates: plates/wire

angelspetrochem

base: chemical-plant, oil-refinery, sulfuric-acid icons
bobplates: liquid fuel, rubber, resin, purified water
bobrevamp: solid-fuel-from-hydrogen, sodium cobaltate, sodium-calcium-chloride
bobwarfare: sulfuric-nitric-acid, nitroglycerin

LovelySanta commented 3 years ago

Due to 25e3ef7 this has to be fixed before release

LovelySanta commented 3 years ago

https://github.com/Arch666Angel/mods/commit/62acfd6036f50d28eb23b68c8228abd79c9736a7 fixes the issues from https://github.com/Arch666Angel/mods/commit/25e3ef7df3d29a6304350af14eb19078edb9cf83, I'll leave this to @kingarthur91 to close if everything is done.

kingarthur91 commented 3 years ago

i think its good now based on @kirazy report on discord

Arch666Angel / mods

[Enhancement] Move icon redefinitions from data-final-fixes to data/data-updates where possible #637