search

Arch666Angel / mods

Angelsmods Repository
https://forums.factorio.com/viewforum.php?f=185
85 stars 61 forks source link

Lithium Issues #701

Closed KiwiHawk closed 3 years ago

KiwiHawk commented 3 years ago

Issues

I noticed that recipes lithium and lithium-water-electrolysis show Bob's Electrolyser in FNEI whereas the other electrolysis recipes (correctly) only show the Angel's electrolysers. This is because these two recipes still have a crafting category of electrolysis rather than petrochem-electrolyser.

image

I also noticed that if Bob's Assembly Machines mod isn't enabled, then only Angel's Electrolyser T1 (not T2 - T4) has crafting category electrolysis added.

image

Suggested fixes

LovelySanta commented 3 years ago

Added the electrolysis group to all electrolysers in https://github.com/Arch666Angel/mods/commit/f55dea0a34bb4a19fbbbe9065544c7dba0043cbe. There should be no need to handle it on a recipe base (only if we want to prevent it from being made in lower tiers... So i'm not changing the crafting categories.

KiwiHawk commented 3 years ago

This still doesn't resolve my original issue which is having the hidden Bob's Electroliser show up in FNEI. I realise that this is an FNEI issue rather than an Angel's issue. The FNEI dev hasn't been responding so I'll fix this part in Sea Block.

KiwiHawk commented 3 years ago

Testing failed: Angel's Electrolyser 2 is not being give crafting category electrolysis. image

LovelySanta commented 3 years ago

Fixed it, made a small error, I moved the wrong line outside the if statement