search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
466 stars 621 forks source link

Bug: "create_as_hint = 2" can still report the same hint repeatedly #3205

Open NewSoupVi opened 4 months ago

NewSoupVi commented 4 months ago

What happened?

If a location has already been checked, but you send a LocationScout for it with create_as_hint = 2, it is reported every time the LocationScout happens.

This seems like a potential oversight.

image

What were the expected results?

A hint originating from a LocationScout with create_as_hint = 2 should only be reported once (or in my opinion never if the location has already been checked)

Software

The Witness Randomizer for Archipelago (Which reports each scout-hint once per session/connect) ArchipelagoTextClient A 0.4.5 game running on archipelago.gg

NewSoupVi commented 4 months ago

For the record, yes, I know I can handle this client side (don't send a LocationScout with create_as_hint = 2 for an already checked location), and that's what I will do. Still seems like unintended behavior though.