search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
480 stars 638 forks source link

LADX: Changed option handling to @dataclass. #3541

Closed mrkssr closed 3 months ago

mrkssr commented 3 months ago

What is this fixing or adding?

LADX options didn't implemented dataclass so far. This leads to a lot of errors while generating a seed. Additionally the player options page got grouped.

How was this tested?

Generated seeds with LADX players locally.

If this makes graphical changes, please attach screenshots.

LADX is not mentioned anymore in the warning at the beginning. image

There are also no warnings anymore while generating a LADX seed which mentioned that getting options from multidata is deprecated. image

The new options groups also changed the visuals on the player options page. image

NewSoupVi commented 3 months ago

I've decided that we will go ahead with hatkirby's version of the option changes as they are a bit cleaner and fix more deprecated stuff

After that, I'm happy to merge the option groups from this PR if you can rebuild them ontop of that one

mrkssr commented 3 months ago

Duplicate of #3542. Option groups part is an own PR at #3560.