I have not reviewed to make sure this actually works, other than the previous review I did before (in the comments on the old PR), and the checking that I did to make sure it functions now.
Also, it is hitting that memory leak assert, which is why it's a draft for now. Need to find some time to figure that out.
And hitting a fill error sometimes, which also needs to be fixed.
If others want to fix the issues here, please, please feel free to do so. I've already spent longer on this than I wanted to, and I haven't had the drive to fix more recently.
How was this tested?
Few test gens. More testing is absolutely needed.
If this makes graphical changes, please attach screenshots.
What is this fixing or adding?
https://github.com/ArchipelagoMW/Archipelago/pull/1613 This PR, mainly, with the merge conflicts fixed since Zig said they didn't want to maintain LADX anymore. Permission to redo their PR: https://discord.com/channels/731205301247803413/1090819435893362768/1254118472741552188
I have not reviewed to make sure this actually works, other than the previous review I did before (in the comments on the old PR), and the checking that I did to make sure it functions now.
Also, it is hitting that memory leak assert, which is why it's a draft for now. Need to find some time to figure that out. And hitting a fill error sometimes, which also needs to be fixed.
If others want to fix the issues here, please, please feel free to do so. I've already spent longer on this than I wanted to, and I haven't had the drive to fix more recently.
How was this tested?
Few test gens. More testing is absolutely needed.
If this makes graphical changes, please attach screenshots.
N/A