search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
412 stars 557 forks source link

TUNIC: Update victory condition #3579

Closed silent-destroyer closed 1 week ago

silent-destroyer commented 2 weeks ago

What is this fixing or adding?

This adds the hero relics to the victory condition when needing to defeat the final boss. They aren't added if hexagon quest is on since you don't fight the final boss for that goal. Also changes the ability unlock pages to not be marked as progression if ability shuffle is turned off.

How was this tested?

Running test gens and checking spoiler logs

If this makes graphical changes, please attach screenshots.

silent-destroyer commented 1 week ago

The changes LGTM and make sense with my understanding of the game. Merged into main and it generates just fine and saw that the items were being required and created appropriately.

Only thing that I think is a tiny bit strange is using > 0 for abilities since if it's greater than 1, that might be weird for filler creation, but I also can't think of a reason these would be greater than 1 in the first place, so it seems fine.

Yeah, '== 1' might've been better here but there should only ever be able to be one of each page in the item pool anyway. That check is to mainly ensure that they're still supposed to be created at all (since in the case of hexagon hunt they get removed from the pool entirely). The pages aren't considered filler so there shouldn't be any chance of them being created multiple times