search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
412 stars 556 forks source link

Installer: Fix .apworld registration #3588

Closed remyjette closed 1 week ago

remyjette commented 2 weeks ago

What is this fixing or adding?

Fixes .apworld registration in Windows so users can double-click a .apworld to install it. Previously the registry entry for shell\open\command wasn't actually being added.

How was this tested?

Created an installer with this inno_setup.iss change, and installed Archipelago. Observed HKCR\Archipelagoworlddata\shell\open\command is now populated in regedit. Also checked my file associations in Windows, .apworld is now associated with Archipelago. Double-clicked pokemon_crystal.apworld and it was copied into custom_worlds with a success message.

remyjette commented 2 weeks ago

I'm not too well versed in how to actually do that.

To build the installer, grab the Inno Setup compiler from https://jrsoftware.org/isinfo.php. Freeze the build with python build_exe in your venv. Open inno_setup.iss in the Inno Setup Compiler, comment out the SignTool= signtool line, then run.

benny-dreamly commented 2 weeks ago

I'm not too well versed in how to actually do that.

To build the installer, grab the Inno Setup compiler from https://jrsoftware.org/isinfo.php. Freeze the build with python build_exe in your venv. Open inno_setup.iss in the Inno Setup Compiler, comment out the SignTool= signtool line, then run.

oh thank you! I can test that for myself then.

EDIT: getting the testing setup, then I can report back :)

benny-dreamly commented 2 weeks ago

I tested it, and used Yacht Dice as a test and it worked and copied the file into the custom_worlds folder. The file association was also made properly.