Spire: Convert options, clean up random calls, and add DeathLink

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server

https://archipelago.gg

Other

469 stars 624 forks source link

Spire: Convert options, clean up random calls, and add DeathLink #3704

Closed Exempt-Medic closed 1 month ago

Exempt-Medic commented 1 month ago

What is this fixing or adding?

Switches Slay the Spire over to the new options API and removed per_slot_randoms and multiworld.random. Also converted the slot data to be identical before and after the changes.

How was this tested?

Comparing spoiler logs before and after the changes, comparing slot_data before and after the changes, connecting to a game, and unit tests.

KonoTyran commented 1 month ago

Actually, I have 1 change that I would like to make, I'll open a PR on your branch later today.

KonoTyran commented 1 month ago

OK my requested addition is up at https://github.com/Exempt-Medic/Archipelago/pull/1