ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
502 stars 657 forks source link

DOOM II: Fix sector 95 assignment in DOOM II MAP17 to correctly flag … #3705

Closed sgrunt closed 1 month ago

sgrunt commented 3 months ago

…the BFG9000 location as in the Yellow Key area

What is this fixing or adding?

Related to APDOOM fix https://github.com/Daivuk/apdoom/pull/21, this fixes a logic error in the DOOM II apworld.

How was this tested?

Double checking locally after making the change that granting access to MAP17 does not flag the BFG9000 location as accessible - only after getting access the MAP17 yellow key area (requiring both the red and yellow keys) is the item considered accessible.

If this makes graphical changes, please attach screenshots.

N/A

Exempt-Medic commented 1 month ago

@Daivuk Just a reminder to look at this

Daivuk commented 1 month ago

@KScl confirmed the change was also made in the tool. So this should be good to go! Approved.