search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
469 stars 624 forks source link

Pokemon Emerald: Send current map to trackers #3726

Closed Zunawe closed 3 weeks ago

Zunawe commented 1 month ago

What is this fixing or adding?

Sends changes to the player's current map to trackers via bounce packets.

How was this tested?

Watched the network logs while changing maps.

Mysteryem commented 3 weeks ago

I think this might not quite work as intended.

The Bounce message sends to all clients that match any of the provided slots, tags or games, so this will send a Bounced message to any clients connected to the players' slot and any clients with the "Tracker" tag.

There's probably not much point sending the Bounced message to every tracker connected to the multiworld. Only specifying to send to clients connected to the player's slot should suffice.

From the Bounce documentation:

Send this message to the server, tell it which clients should receive the message and the server will forward the message to all those targets to which any one requirement applies.

NewSoupVi commented 3 weeks ago

Oh, it's an or relationship? My bad, I remembered that wrong.

NewSoupVi commented 3 weeks ago

So it is.

NewSoupVi commented 3 weeks ago

Well, there should be a short term fix, but for a long term fix, I made this: https://github.com/ArchipelagoMW/Archipelago/pull/3845