While #3611 fixed !remaining to not throw an exception in all cases, items that were for players playing different games would all show up as "Unknown item", greatly limiting its use outside of single-player or single-game multiworlds. This changes get_remaining to return a tuple of (slot, item_id) instead of just the item_id on its own, and then changes cmd_remaining to use that newly given information to fetch item names from the correct game.
How was this tested?
Running a multiworld with multiple different games, enabling and using !remaining.
If this makes graphical changes, please attach screenshots.
What is this fixing or adding?
While #3611 fixed !remaining to not throw an exception in all cases, items that were for players playing different games would all show up as "Unknown item", greatly limiting its use outside of single-player or single-game multiworlds. This changes get_remaining to return a tuple of (slot, item_id) instead of just the item_id on its own, and then changes cmd_remaining to use that newly given information to fetch item names from the correct game.
How was this tested?
Running a multiworld with multiple different games, enabling and using !remaining.
If this makes graphical changes, please attach screenshots.
Screenshot of !remaining working with cross-game items after this change