ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
481 stars 638 forks source link

Core: use base collect/remove for item link groups #3999

Closed qwint closed 1 week ago

qwint commented 1 week ago

What is this fixing or adding?

use base collect/remove for item link groups

How was this tested?

not in the slightest, not even sure what the get part does to be honest

If this makes graphical changes, please attach screenshots.

NewSoupVi commented 1 week ago

In favor of this. Anything that doesn't work with this is a bug itself, imo

NewSoupVi commented 1 week ago

Doesn't work...

  File "F:\Archipelago\worlds\AutoWorld.py", line 509, in collect
    name = self.collect_item(state, item)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: World.collect_item() missing 1 required positional argument: 'item'

:( Idk how to make it work

NewSoupVi commented 1 week ago

Turns out the classmethod might not be necessary

NewSoupVi commented 1 week ago

Yeah this works I think