ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
521 stars 678 forks source link

Bug: Pokemon RB Item Location Incorrect #4202

Open nmorale5 opened 1 week ago

nmorale5 commented 1 week ago

What happened?

In worlds/pokemon_rb/locations.py there is an item with this location: LocationData("Victory Road 2F-W", "West Item", "TM05 Mega Kick", rom_addresses["Missable_Victory_Road_2F_Item_3"], Missable(94)), However, the region should be "Victory Road 2F-C", not "Victory Road 2F-W", since "Victory Road 2F-C" is the region that also contains the jugglers, black belt, and tamer that the item is near. Here is a map of the area for reference. image

What were the expected results?

In an entrance randomizer, the player could come from the west ladder and not have strength. In this case, archipelago would consider the item in-logic, even though it's inaccessible.

Software

While playing

nmorale5 commented 1 week ago

It also looks like the Cooltrainer F's in Victory Road 3F are also swapped; specifically, "Cooltrainer F 1" is said to be in "Victory Road 3F-S", but actually it is in "Victory Road 3F". And "Cooltrainer F 2" is said to be in "Victory Road 3F", but actually it is in "Victory Road 3F-S"

nmorale5 commented 1 week ago

Also "Psychic 1" in "Saffron Gym-NE" and "Psychic 3" in Saffron Gym-SE" should be swapped