SMW: Add Text Rando and Plando

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server

https://archipelago.gg

Other

515 stars 671 forks source link

SMW: Add Text Rando and Plando #4210

Open josephwhite opened 4 days ago

josephwhite commented 4 days ago

What is this fixing or adding?

Adds a plando text option for Super Mario World.

Gives players the ability to change the intro text.

How was this tested?

Several seed and rom generations with a single SMW player.

Stress tested by using very long strings. Decided to add trunc anyways.
Regression tested by removing plando text option and observing vanilla text.

If this makes graphical changes, please attach screenshots.

game: Super Mario World
Super Mario World:
  # ...
  plando_texts:
    - text: "This isn't vanilla."
      at:
        intro: 1
      percent: 99

ArchipelagoMW-SMWPlandoTextDemo

PoryGone commented 4 days ago

I'll be honest, I don't really see the point of this feature, and as such, I'm not really in a position to spend the time testing it or enumerating the several stylistic changes that would need to be made for the new code to match the code around it.

josephwhite commented 2 days ago

I am currently rewriting to add a Text Shuffle option which will randomize the text from messages boxes to messages from a custom pool. I guess it would have made more sense to start there (rando before plando), but I am going to have to put this back in drafts while I map out the rest of the message boxes.

Text rando is an feature that is present in a few other AP clients (ALttP, LADX, etc) that adds a change to aesthetics.
Plando Text is one of the more unique randomizer features that is supported by core options, and would be cool to see in more games that have their randomizable text mapped out properly.
The POINTS OF ADVICE, while helpful to new players of SMW, may not be as helpful in AP which makes them the first candidates to get randomized for something more entertaining.

PoryGone commented 2 days ago

I'm going to get ahead of you spending too much time on this and say that lx5 and I (mostly him) have a branch with a significant amount of rewrites to the code that are liable to conflict with any major feature development. I'll talk it over with him and see if this is a feature we want to support, and if so, we'll probably just incorporate it ourselves.