search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
521 stars 678 forks source link

HK: Fix charm cost when generating config from website #4211

Closed Tyranozomby closed 1 week ago

Tyranozomby commented 1 week ago

In RandomCharmCosts, range_start and range_end don't cover -1 and -2 (0 to 240).

Because of the way the options webpage is generated, the range input in HTML is also limited to this range and wouldn't return a value below 0 in the generated YAML, even though it was showing a negative value.

Hence, turning every charm cost to 0, instead of the expected vanilla cost for -1 or shuffled for -2.

Exempt-Medic commented 1 week ago

This was already fixed: https://github.com/ArchipelagoMW/Archipelago/pull/3613

qwint commented 1 week ago

For clarity I am also rejecting this PR because the root cause was a webhost bug and something that is already fixed on main,

also as a bonus this change allows vanilla and shuffled as valid values for random which I would also reject it for