search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
515 stars 671 forks source link

core: persist hints even if previously found #4214

Closed qwint closed 3 days ago

qwint commented 3 days ago

What is this fixing or adding?

adding already found hints to ctx.hints so create_as_hint=2 knows they were previously hinted and doesn't send the message in chat about them

How was this tested?

wasn't; vi test it for me please :)

If this makes graphical changes, please attach screenshots.

NewSoupVi commented 3 days ago

Tested the following situations:

  1. Location is found -> client scouts it for the first time -> client scouts it for the second time
  2. Client scouts location for the first time -> Location is found -> client scouts it for the second time

The original reason for this change was that hint cost didn't behave correctly. This should not be an issue anymore because hint cost calculation was revamped and moved elsewhere. But, I verified it just to be sure.

  1. Player hints an already found check
  2. Player hints a not already found check
  3. Player hints an already found check that was previously scouted
  4. Player hints a not already found check that was previously scouted

All of these scenarios behaved as expected with the change.