search

ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
521 stars 678 forks source link

Core: Fix Fill choking on itself in minimal + full games #4225

Open NewSoupVi opened 4 days ago

NewSoupVi commented 4 days ago

Fixes https://github.com/ArchipelagoMW/Archipelago/issues/4224

Basically, the "cleanup" step is too overzealous and "cleans up" cases that can actually be fixed by accessibility_corrections later, leading to failed seeds that would have generated perfectly fine otherwise

I knew this fix was gonna be like one line

NewSoupVi commented 4 days ago

Idk about the formatting here, if someone who actually knows PEP8 and doesn't let ruff do it for them wants to check it that would be appreciated

NewSoupVi commented 4 days ago

Part of me is also wondering what this part of the code is even doing, it seems like it might be a relic of the past that isn't hurting anything but doesn't need to be here anymore? Maybe one of the core devs who worked on this part of the code can explain

Either way, this fix does fix the issue, so