ArchipelagoMW / Archipelago

Archipelago Multi-Game Randomizer and Server
https://archipelago.gg
Other
521 stars 678 forks source link

LADX: move client out of root #4226

Open threeandthreee opened 3 days ago

threeandthreee commented 3 days ago

What is this fixing or adding?

Moves the client out of root.

Much easier to distribute beta clients like this, and as I understand it we want this stuff out of root anyway.

How was this tested?

Client works, patcher works, could use more.

threeandthreee commented 3 days ago

@palex00 would you mind testing?

Berserker66 commented 3 days ago

old client needs to be explicitly deleted in inno_setup.iss as well.

Zunawe commented 3 days ago

If you're removing the top-level script entirely, you'll want to modify inno_setup.iss to change the windows file extension registration from the LADX client exe to the launcher exe.

threeandthreee commented 3 days ago
Root: HKCR; Subkey: ".apladx";                                   ValueData: "{#MyAppName}ladxpatch";        Flags: uninsdeletevalue; ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch";                     ValueData: "Archipelago Links Awakening DX Patch"; Flags: uninsdeletekey;   ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch\DefaultIcon";         ValueData: "{app}\ArchipelagoLauncher.exe,0";                           ValueType: string;  ValueName: "";
Root: HKCR; Subkey: "{#MyAppName}ladxpatch\shell\open\command";  ValueData: """{app}\ArchipelagoLauncher.exe"" ""%1""";                  ValueType: string;  ValueName: "";

Like this?